Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change FoxOS to WolfOS #1534

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

Change FoxOS to WolfOS #1534

wants to merge 15 commits into from
+15 −17

Conversation

WolfTech-Innovations
Copy link
Contributor

No description provided.

@CarterLi
Copy link
Member

CarterLi commented Feb 1, 2025

Was the OS renamed? Any context?

You need to move the distro definition to W section.

@WolfTech-Innovations
Copy link
Contributor Author

WolfTech-Innovations commented Feb 1, 2025 •
edited
Loading

For context, yes it was

@WolfTech-Innovations
Copy link
Contributor Author

WolfOS has been moved to W.

@FabioLolix FabioLolix mentioned this pull request Feb 1, 2025
Open
@CarterLi
Copy link
Member

CarterLi commented Feb 1, 2025

You should rearrange it in alphabetical order

@WolfTech-Innovations
Copy link
Contributor Author

I did.

@komaru-meow
Copy link
Contributor

komaru-meow commented Feb 5, 2025 •
edited
Loading

I did.

WolfOS is put before "WiiLinux", and the letter "i" comes before the letter "o".

@komaru-meow
Copy link
Contributor

image
are you kidding me? to be honest, if you want, i can make a pr on your fork to move it to the correct place

@WolfTech-Innovations
Copy link
Contributor Author

Alright, yeah

@WolfTech-Innovations
Copy link
Contributor Author

All done

CarterLi
CarterLi reviewed Feb 14, 2025
View reviewed changes
src/logo/builtin.c
@@ -4959,6 +4951,7 @@ static const FFlogo V[] = {
};

static const FFlogo W[] = {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

CarterLi
CarterLi reviewed Feb 14, 2025
View reviewed changes
src/logo/builtin.c
// LAST
{},
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the new line back

@CarterLi
Copy link
Member

Your logo is too wide. See the requirement here: https://github.com/fastfetch-cli/fastfetch/issues/new?template=logo_request.yml

@komaru-meow
Copy link
Contributor

komaru-meow commented Feb 14, 2025 •
edited
Loading

I would also recommend squashing the commits, 11 commits for a simple distro rename on fastfetch is crazy.

@CarterLi
Copy link
Member

I would also recommend squashing the commits, 11 commits for a simple distro rename on fastfetch is crazy.

I always use Squash and merge so it is ok

@WolfTech-Innovations
Copy link
Contributor Author

All issues fixed.

@komaru-meow
Copy link
Contributor

you don't need to rebase the branch every time changes are added, the maintainer can rebase and merge

@CarterLi
Copy link
Member

Please fix the newline issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarterLi CarterLi CarterLi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WolfTech-Innovations @CarterLi @komaru-meow