-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarks for busboy #40
Conversation
} | ||
}), | ||
mb = 100, | ||
buffer = createMultipartBuffer(boundary, mb * 1024 * 1024), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably should extract shared part somewhere to reduce risk of benchmarks diverging over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Fastify-Busboy and Old-Busboy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the very least, but I assume there is lots of duplication across all benchmarks (which we'll need to revise eventually too).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we do it in another PR? Benchmarks against other Projects has to be any way cleaned up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure!
btw. The comparison:
|
Tadaaa!
I modified the dicer benchmark for busboy. I also added the old busboy for comparison, but i did not add a npm package.json script for benching against the old busboy. I can add it if you like.
I moved the dicer benchmarks into the bench folder. Looks clear. ;)
Checklist
npm run test
andnpm run benchmark
and the Code of conduct