New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC6717 conformancy #112

Merged

Uzlopak merged 10 commits into master from rfc6717-conformancy

Dec 6, 2022

Contributor

Uzlopak commented Nov 29, 2022 •

edited

Loading

Changes:
removing basic-auth-package
Sending by default the auth-token charset="UTF-8".
Checking for control characters in user-id and password (lacking in basic-auth-package)
adding a strictCredentials options as basic-auth implemented actually the credentials schema wrong. BWS is not in the ABNF schema of the credentials schema. BWS is extended to also cover tab.

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

Uzlopak added 6 commits

November 29, 2022 14:10


          integrate basic-auth


          make credentials more strict

fe2fd40


          add strict option for fallback opportunity

84a561f


          modify strictness

4006ac4


          handle charset auth-token in challenge properly

7055ae0


          add options to readme

3f5e985

Uzlopak requested review from mcollina, delvedor, Fdawgs, climba03003, Eomm and jsumners and removed request for mcollina and delvedor

November 29, 2022 14:28

jsumners reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved


          Update README.md

889cc95

Co-authored-by: James Sumners <[email protected]>

climba03003 reviewed

View reviewed changes

index.js Show resolved Hide resolved


          Merge branch 'master' into rfc6717-conformancy

Contributor Author

Uzlopak commented Nov 29, 2022

Based on using autocannon on the example.js I can determine that the performance did not degrade on invalid and valid credentials.

Uzlopak commented

View reviewed changes

README.md Outdated Show resolved Hide resolved


          rename strict to strictCredentials

d1987d4

Eomm reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved


          Update README.md

c91af1a

Co-authored-by: Manuel Spigolon <[email protected]>

Contributor Author

Uzlopak commented Nov 29, 2022 •

edited

Loading

I could set strictCredentials default to false, if you worried about releasing a major after a short time?
Then it would be only a minor version change i think.

mcollina approved these changes

View reviewed changes

Member

mcollina left a comment

lgtm

Uzlopak merged commit 330e6fb into master

Uzlopak deleted the rfc6717-conformancy branch

December 6, 2022 11:24

renovate bot referenced this pull request in tomacheese/telcheck


          chore(deps): update dependency @fastify/basic-auth to v5.1.0 (#361)

6c0a1d1

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/basic-auth](https://togithub.com/fastify/fastify-basic-auth)
| [`5.0.0` ->
`5.1.0`](https://renovatebot.com/diffs/npm/@fastify%2fbasic-auth/5.0.0/5.1.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fbasic-auth/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fbasic-auth/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fbasic-auth/5.0.0/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fbasic-auth/5.0.0/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-basic-auth
(@&#8203;fastify/basic-auth)</summary>

###
[`v5.1.0`](https://togithub.com/fastify/fastify-basic-auth/releases/tag/v5.1.0)

[Compare
Source](https://togithub.com/fastify/fastify-basic-auth/compare/v5.0.0...v5.1.0)

#### What's Changed

- add example by [@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[https://github.com/fastify/fastify-basic-auth/pull/111](https://togithub.com/fastify/fastify-basic-auth/pull/111)
- build(deps-dev): bump tsd from 0.24.1 to 0.25.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-basic-auth/pull/113](https://togithub.com/fastify/fastify-basic-auth/pull/113)
- RFC6717 conformancy by [@&#8203;Uzlopak](https://togithub.com/Uzlopak)
in
[https://github.com/fastify/fastify-basic-auth/pull/112](https://togithub.com/fastify/fastify-basic-auth/pull/112)
- chore(.gitignore): add clinic by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-basic-auth/pull/114](https://togithub.com/fastify/fastify-basic-auth/pull/114)
- chore(.gitignore): add bun lockfile by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-basic-auth/pull/115](https://togithub.com/fastify/fastify-basic-auth/pull/115)
- build(deps-dev): bump tsd from 0.25.0 to 0.26.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-basic-auth/pull/116](https://togithub.com/fastify/fastify-basic-auth/pull/116)
- build(deps-dev): bump tsd from 0.26.1 to 0.27.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-basic-auth/pull/117](https://togithub.com/fastify/fastify-basic-auth/pull/117)
- build(deps-dev): bump tsd from 0.27.0 to 0.28.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-basic-auth/pull/118](https://togithub.com/fastify/fastify-basic-auth/pull/118)
- ci: only trigger on pushes to main branches by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-basic-auth/pull/119](https://togithub.com/fastify/fastify-basic-auth/pull/119)
- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 18.16.5 to
20.1.0 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-basic-auth/pull/120](https://togithub.com/fastify/fastify-basic-auth/pull/120)
- build(deps-dev): bump tsd from 0.28.1 to 0.29.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-basic-auth/pull/121](https://togithub.com/fastify/fastify-basic-auth/pull/121)
- perf: use `node:` prefix to bypass require.cache call for builtins by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-basic-auth/pull/122](https://togithub.com/fastify/fastify-basic-auth/pull/122)
- chore: add `.gitattributes` file by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-basic-auth/pull/124](https://togithub.com/fastify/fastify-basic-auth/pull/124)
- chore(package): explicitly declare js module type by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-basic-auth/pull/125](https://togithub.com/fastify/fastify-basic-auth/pull/125)

**Full Changelog**:
fastify/fastify-basic-auth@v5.0.0...v5.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tomacheese/telcheck).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

climba03003 climba03003 left review comments

Eomm Eomm left review comments

jsumners jsumners left review comments

mcollina mcollina approved these changes

Fdawgs Awaiting requested review from Fdawgs

Labels

None yet