Add TS type definitions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind adding a unit test? Check out https://github.com/fastify/fastify-static for an example. |
|
For sure, done! To follow the same structure as that one, I also moved the rest of the unit tests to a |
Eomm
reviewed
Oct 17, 2019
| @@ -0,0 +1,29 @@ | |||
| // Definitions by: ricardo-devis-agullo <https://github.com/ricardo-devis-agullo> | |||
There was a problem hiding this comment.
as this https://github.com/fastify/fastify-bearer-auth/pull/29/files#r336102699 feedback I would remove this.
Your contribution will remain in github and git blame forever 💪🏻😃
If you found it in other plugins it is an oversight
|
why is this still open? |
|
@Eomm I'll drop that line in a commit on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TypeScript definition file.
Closses #12
Checklist
npm run testandnpm run benchmark