Support fastify v3 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
mcollina
requested changes
Apr 26, 2020
There was a problem hiding this comment.
I would point this branch to https://github.com/fastify/fastify-auth/pull/66/files as a dependency instead.
index.js
Outdated
| @@ -64,6 +64,6 @@ function getAuthenticateHeader (authenticate) { | |||
| } | |||
|
|
|||
| module.exports = fp(basicPlugin, { | |||
| fastify: '>=1.0.0', | |||
| fastify: '>=3.0.0', | |||
There was a problem hiding this comment.
this could be >=3.x now right?
package.json
Outdated
| "fastify-auth": "^0.3.0", | ||
| "standard": "^11.0.1", | ||
| "tap": "^12.0.1" | ||
| "fastify": "^3.0.0-alpha.1", |
package.json
Outdated
| "standard": "^11.0.1", | ||
| "tap": "^12.0.1" | ||
| "fastify": "^3.0.0-alpha.1", | ||
| "fastify-auth": "^0.7.2", |
There was a problem hiding this comment.
This needs to be published and then it can be updated with the new types @mcollina is fastify-auth ready to go? I can publish major if so
mcollina
approved these changes
May 8, 2020
There was a problem hiding this comment.
lgtm (I've updated this.
@Ethan-Arrowood can you take a look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.
@Ethan-Arrowood sorry if I took this one even if you put your name on it, but I'm working on a demo with Fastify v3 and I need this plugin ;)
Note: I've disabled the test with
fastify-auth, as it's not ready for v3 yet.Checklist
npm run testandnpm run benchmark