Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fastify-websocket, proxy ws events directly #122

Merged
merged 9 commits into from
Dec 18, 2020
Merged

Remove fastify-websocket, proxy ws events directly #122

merged 9 commits into from
Dec 18, 2020

Conversation

greguz
Copy link
Contributor

@greguz greguz commented Dec 16, 2020

Notable changes:

  • Remove fastify-websocket: proxy ws events directly.
  • Proxy query string with WebSockets.
  • Support prefix and rewritePrefix options with WebSockets.
  • Support custom ws options for both client and server.
  • Add socket.io tests.

Checklist

@greguz greguz mentioned this pull request Dec 16, 2020
Closed
mcollina
mcollina requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

index.js Show resolved Hide resolved
mcollina
mcollina requested changes Dec 16, 2020
View reviewed changes
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
mcollina
mcollina requested changes Dec 17, 2020
View reviewed changes
test/websocket.js Outdated Show resolved Hide resolved
test/socket.io.js Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 0f7b501 into fastify:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greguz @mcollina