Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package-lock.json included with repo #238

Closed
Fdawgs opened this issue Apr 29, 2021 · 2 comments
Closed

package-lock.json included with repo #238

Fdawgs opened this issue Apr 29, 2021 · 2 comments

Comments

@Fdawgs
Copy link
Member

Fdawgs commented Apr 29, 2021

Should package-lock.json be included with this repo?

As recommended by @mcollina fastify/fluent-json-schema#91 (review) and Snyk they pose a security risk.

If it does need to be included, we could add linting for it to the CI with lockfile-lint
@mcollina
Copy link
Member

It's needed as next and dependencies ship breaking changes in minor/patch releases.

@Fdawgs
Copy link
Member Author

Fdawgs commented Apr 29, 2021

It's needed as next and dependencies ship breaking changes in minor/patch releases.

Cheers, thanks for clarifying @mcollina

@Fdawgs Fdawgs closed this as completed Apr 29, 2021
@rbeer rbeer mentioned this issue Dec 27, 2021
Merged
4 tasks
This was referenced Aug 13, 2022
Merged
Closed
@Fdawgs Fdawgs mentioned this issue Jun 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @Fdawgs