Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update under-pressure #591

Merged
merged 2 commits into from
Aug 13, 2022
Merged

fix: update under-pressure #591

merged 2 commits into from
Aug 13, 2022

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Aug 13, 2022

@Eomm Eomm requested a review from SimenB August 13, 2022 08:02
SimenB
SimenB approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet 👍

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 13, 2022 •
edited
Loading

What is with the package-lock? It did not change. So i assume you just touched the package json without doing an npm i.
Can we actually drop the package-lock generation?

Answering my own question:
No
#238

Uzlopak
Uzlopak requested changes Aug 13, 2022
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is with the package lock?

Uzlopak
Uzlopak approved these changes Aug 13, 2022
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the package-lock

@Uzlopak Uzlopak merged commit 3e05d99 into master Aug 13, 2022
@Uzlopak Uzlopak deleted the Eomm-patch-1 branch August 13, 2022 10:05
@SimenB
Copy link
Member

SimenB commented Aug 13, 2022

release? 😀

@SimenB
Copy link
Member

SimenB commented Aug 26, 2022

@mcollina could you release this please? 😀 I need fastify/fastify-plugin#193 to be in semver range 🙂

@SimenB SimenB mentioned this pull request Aug 26, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eomm @Uzlopak @SimenB