Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic PR #55

Merged
merged 2 commits into from
Dec 19, 2021
Merged

automatic PR #55

merged 2 commits into from
Dec 19, 2021

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Dec 18, 2021

This is an automatic PR created with massive-wax!

@Eomm Eomm requested a review from Fdawgs December 18, 2021 11:25
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Eomm Eomm merged commit 75ea26b into fastify:master Dec 19, 2021
@Eomm Eomm deleted the automerge-3 branch December 19, 2021 17:46
@climba03003
Copy link
Member

climba03003 commented Dec 20, 2021

@Fdawgs @Eomm do you have time to double check the ci.yml?
I can see that it is not the only one exist inside this repo.

  1. on is formatted as 'on'
  2. jobs.strategy.matrix.os using the dash style for array
  3. jobs.strategy.matrix.node-version using the dash style for array

I have no strong opinion on 2. and 3., but it is inconsistent for 1.

https://github.com/fastify/fastify-postgres/blob/acac8a491c7f99f9183323593b46c71e5e431246/.github/workflows/ci.yml
https://github.com/fastify/skeleton/blob/e5bc2b50d256e8bec767ffe8fbfc8afb39bf2207/.github/workflows/ci.yml
https://github.com/fastify/fastify-cors/blob/ce170a34ff6086a9e279ff667b9f9d0618e252a4/.github/workflows/ci.yml
https://github.com/fastify/fastify-auth/blob/f1a94c44b6a765cc4a2f829e26fd63e4f2f7d012/.github/workflows/ci.yml
https://github.com/fastify/fastify-csrf/blob/759ac65bab3a73b5f79c3087be56e2759ac10970/.github/workflows/node.js.yml
https://github.com/fastify/fastify-error/blob/c646efd012e44800e8148d250eaca7eab4afa89c/.github/workflows/ci.yml"
https://github.com/fastify/light-my-request/blob/8fab2a1dd39b7dad99add887e21d41839814aae7/.github/workflows/ci.yml
https://github.com/fastify/fastify-csrf/blob/759ac65bab3a73b5f79c3087be56e2759ac10970/.github/workflows/ci.yml
https://github.com/fastify/fastify-rate-limit/blob/296e24dfd0cedbf0ecd17ae5f13505347922b6c9/.github/workflows/ci.yml
https://github.com/fastify/fastify-rate-limit/blob/296e24dfd0cedbf0ecd17ae5f13505347922b6c9/.github/workflows/ci.yml
https://github.com/fastify/create-fastify/blob/c60223456ead2f20ebc200d683efa9ce4873dfce/.github/workflows/ci.yml
https://github.com/fastify/fastify-mysql/blob/1000fea47b53fe682786f6b59b30fb28b815ad8c/.github/workflows/ci.yml
https://github.com/fastify/fastify-accepts-serializer/blob/c4bdb46cc5fb38de894342a428843c00fdb3958a/.github/workflows/ci.yml
https://github.com/fastify/fastify-url-data/blob/2330d3c086219d5558e778d04dae03b6077e2f58/.github/workflows/ci.yml
https://github.com/fastify/fastify-plugin/blob/508aedef4f288eb88b4ea98216e33a0854d98ee1/.github/workflows/ci.yml
https://github.com/fastify/fastify-express/blob/02876b5db99bc7519ecbb0c4447efc12ca59c7ff/.github/workflows/nodejs.yml
https://github.com/fastify/fastify-etag/blob/77b5ad9b41d37f1317b8f9375573f2b1d1470bde/.github/workflows/ci.yml
https://github.com/fastify/fastify-cookie/blob/abb442b0ab0e269f7b12975e2fa30f810072a468/.github/workflows/ci.yml
https://github.com/fastify/fastify-caching/blob/9568a627e9079b4c00f330a42465619908695488/.github/workflows/ci.yml
https://github.com/fastify/fastify-flash/blob/c59915063172d7dbeebe41e165a3b925ac206ec4/.github/workflows/ci.yml
https://github.com/fastify/fastify-websocket/blob/01467e31e530ba2bc00e16e76ef0de123ef084ae/.github/workflows/ci.yml
https://github.com/fastify/fastify-diagnostics-channel/blob/0c8793a633f1607235dab519bf17b5cf27961a63/.github/workflows/ci.yml
https://github.com/fastify/fastify-basic-auth/blob/26be1bc3c33b4d10a899c4535860803e7dd5603e/.github/workflows/ci.yml
https://github.com/fastify/fastify-nextjs/blob/03e47202fb367a2ac7c174bf784c300bf1c1df67/.github/workflows/ci.yml
https://github.com/fastify/fastify-http-proxy/blob/b4575deef5fe201857a691a165c0b34a113a9c14/.github/workflows/ci.yml
https://github.com/fastify/fastify-circuit-breaker/blob/3549b3203fbb6b45ec607ccc75ba88bbb6b74853/.github/workflows/ci.yml
https://github.com/fastify/fastify-redis/blob/b38b10081eca3856b6bb8ed755f7f91fab4dd60c/.github/workflows/ci.yml
https://github.com/fastify/releasify/blob/9a9c5787eff34fe7e1368a8c4b16e2df5097b48c/.github/workflows/ci.yml
https://github.com/fastify/fastify-compress/blob/5845e5d8dc647a35c180209c1f2b52e2c8c538b4/.github/workflows/ci.yml
https://github.com/fastify/fastify-helmet/blob/f6dd255fd1d705b7da2e514a1e2453ccff476d05/.github/workflows/ci.yml
https://github.com/fastify/fastify-warning/blob/819b0bcb53a9856e424e5512d3ecc6936c2e0a68/.github/workflows/ci.yml
https://github.com/fastify/fastify-sensible/blob/7d77bdc985e6a431e037c43ef7c4bb950b579798/.github/workflows/ci.yml
https://github.com/fastify/fastify-cli/blob/74d454a7c8dff7dc956e4c6440450b076f77e548/.github/workflows/ci.yml
https://github.com/fastify/fastify-soap-client/blob/7bf25c43aadaf6e394daa73f0d4610dacc1dda8e/.github/workflows/ci.yml
https://github.com/fastify/fastify-mongodb/blob/e3c874fa7cde50c1a85fc934e722542c384b108f/.github/workflows/ci.yml
https://github.com/fastify/middie/blob/5b22b3f05d45bced15c17371689208763e3f2d5b/.github/workflows/ci.yml
https://github.com/fastify/fastify-accepts/blob/188f0bbb29cd40419ad6c5ffcce25e01fad4e59e/.github/workflows/ci.yml
https://github.com/fastify/fastify-bearer-auth/blob/32e948abc5204b18fecafad62b91c059b9018dce/.github/workflows/ci.yml
https://github.com/fastify/fastify-elasticsearch/blob/77e893c0949c5023a60ce7353362509e60680cf0/.github/workflows/ci.yml
https://github.com/fastify/fastify-jwt/blob/8b27e9a615134794aa6d1ebb783c4f73856dc7bc/.github/workflows/ci.yml
https://github.com/fastify/fastify-static/blob/62fbc59ca0d46c15e576861f9abe227faf8dde4f/.github/workflows/ci.yml
https://github.com/fastify/fastify-leveldb/blob/289a9cb196e02bda73e930b6889f04f73554d0c7/.github/workflows/ci.yml
https://github.com/fastify/fastify-autoload/blob/6d8e0c3debc8c0f3588c694e1d03a0e2b0548973/.github/workflows/ci.yml

@Eomm
Copy link
Member Author

Eomm commented Dec 20, 2021

I will update them within the new centralized wf fastify/workflows#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants