-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): replaced jest with node:test #245
chore(tests): replaced jest with node:test #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@mcollina build is failing on Node 16, I suspect something incompatible with c8 or even node:test. Are we supposed to still support Node 16 with this library? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please target next and modify this line to test only on 18, 20, 22:
node-versions: '["16", "18", "20", "22"]' |
595b4b5
to
0bac57b
Compare
Thank you for this @floridemai 🙌 |
We can just drop node.js v16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I think to keep things organized we should keep CI changes in |
Thanks a lot for the PR! |
* chore(tests): replaced jest with node:test * chore: removed node 16 from version targets
Closes #243
Updated all test files to work with
node:test
runner. Everything went smooth with only two notes: certain expected objects needed and addiional$id: undefined
property and a test where the error type was invalid.Checklist
npm run test
andnpm run benchmark
and the Code of conduct