-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: subdirectory pull requests from dependabot #61
fix: subdirectory pull requests from dependabot #61
Conversation
It looks like the latest version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
should I have included dist or is this done when released? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
We should make an automatic dist generation on release / commit to master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dist folder not updated. make sure husky hooks are run please. https://github.com/fastify/github-action-merge-dependabot/blob/main/.husky/pre-commit
I had a look why the hook wasn't run (I didn't commit with --skip-verify :)) and it's never run, the pre-commit script isn't executable. I will update this pull request with both the dist and chmod +x :) |
Thanks. I've done the last releases of this package and it always ran here, I guess something must have gone awry |
updated this pull request to include dist, and made the .husky/pre-commit script executable too. |
When dependabot sends pull requests for subdirectories in a monorepo the current regex matching the versions fails.
Fixed the regex and added a test too.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct