Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont overwrite global config when setting unlimited #94

Closed
wants to merge 1 commit into from

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Dec 3, 2023

Another approach to fix #88

Checklist

@Uzlopak Uzlopak requested review from jsumners and Eomm December 3, 2023 23:21
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we need to support more clearly due the fastify test:

  • update the readme (the emitter is no more a map of boolean)
  • how the user check if a code has been emitted?
  • how the user set that a code has been emitted?

Could you add some info as comment?
I do bit ops once per year and I don't remember it, so reading back this code would become just stressful

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a test that proves it is still possible to reset the state of an error by setting its emitted "property" to false.

@Uzlopak Uzlopak closed this Dec 10, 2023
@jsumners jsumners deleted the fix-88 branch December 10, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All the warnings are either "fire once" or "unlimited" based on the flag passed to last "create" method
3 participants