Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds OpenStack logging support #132

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Adds OpenStack logging support #132

merged 1 commit into from
Jun 29, 2020

Conversation

mccurdyc
Copy link
Collaborator

Relevant (Referenced) Link(s)

Validation

$ make all

git clone [email protected]:mccurdyc/cli.git /tmp/cli && \
(
    cd /tmp/cli && \
    git checkout mccurdyc/logging-openstack && \
    make test && \
    rm -rf /tmp/cli \
)

@mccurdyc mccurdyc requested review from ezkl and phamann June 24, 2020 18:56
mccurdyc
mccurdyc commented Jun 24, 2020
View reviewed changes
pkg/app/run_test.go Outdated Show resolved Hide resolved
@mccurdyc mccurdyc marked this pull request as ready for review June 24, 2020 19:02
@mccurdyc
Copy link
Collaborator Author

Seems like the tests failed for something unrelated to this change - https://github.com/fastly/cli/pull/132/checks?check_run_id=804681566

@phamann
Copy link
Member

phamann commented Jun 25, 2020

I fixed the broken tests in #133 so if you rebase from master they should now pass.

@mccurdyc
Adds OpenStack logging support
6522a1c 
Signed-off-by: Colton J. McCurdy <[email protected]>
@mccurdyc mccurdyc added the enhancement New feature or request label Jun 25, 2020
phamann
phamann approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM - Do you want me to release this or do you want to do it?

@mccurdyc
Copy link
Collaborator Author

I'll do it :)

@mccurdyc mccurdyc merged commit 93a9b0d into fastly:master Jun 29, 2020
@mccurdyc mccurdyc deleted the mccurdyc/logging-openstack branch June 29, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

@ezkl ezkl Awaiting requested review from ezkl

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccurdyc @phamann