The manifest_version should default to 1 if missing. #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailan
approved these changes
Mar 16, 2021
Integralist
force-pushed
the
integralist/20210316_manifest_default_1
branch
from
a58de47 to
31f3849
Compare
|
Kailan, Patrick and myself have discussed the implementation internally and settled on a solution (which is now implemented). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Originally if the manifest_version field was missing from the fastly.toml manifest file, then we would return an error.
Solution: We should instead set a default value of
1.Notes: to issue an appropriate “warning” message, it required the manifest
Fileobject to have access to a consistent output stream. This meant everywhere we callc.manifest.File.Read(manifest.Filename)(which is in every command) I’ve had to precede it with a call toc.manifest.File.SetOutput(c.Globals.Output).