Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for file_max_bytes configuration for azure logging endpoint #251

Merged

Conversation

kellymclaughlin
Copy link
Contributor

Support file_max_bytes configuration option for azure blob storage logging endpoint. Follows from fastly/go-fastly#255.

@Integralist Integralist added the enhancement New feature or request label Apr 14, 2021
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you resolve the go mod/sum conflicts and then I can get this merged.

@kellymclaughlin kellymclaughlin force-pushed the azure-logging-file-max-bytes branch from 21d6685 to df56ca5 Compare April 14, 2021 14:15
@kellymclaughlin kellymclaughlin force-pushed the azure-logging-file-max-bytes branch from df56ca5 to 41135b1 Compare April 14, 2021 14:16
@Integralist Integralist merged commit 3b3086c into fastly:master Apr 14, 2021
@kellymclaughlin kellymclaughlin deleted the azure-logging-file-max-bytes branch April 15, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants