Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't persist --service-id flag value to manifest #307

Merged
merged 1 commit into from
Jun 14, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions pkg/compute/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,10 @@ func (c *DeployCommand) Exec(in io.Reader, out io.Writer) (err error) {
if err != nil {
return err
}
err = updateManifestServiceID(&c.manifest.File, ManifestFilename, progress, serviceID)
if err != nil {
return err
}
}

// If the user has specified a Service ID, then we validate it has the
Expand Down Expand Up @@ -274,17 +278,6 @@ func (c *DeployCommand) Exec(in io.Reader, out io.Writer) (err error) {
}
}

// We only want to update the manifest if it's the first time deploying and
// so we will have only just created a new service. If the Service ID is
// provided by the flag and not the file, then we'll also store that ID
// within the manifest.
if sidSrc == manifest.SourceUndefined || sidSrc != manifest.SourceFile {
err = updateManifestServiceID(&c.manifest.File, ManifestFilename, progress, serviceID)
if err != nil {
return err
}
}

cont, err := pkgCompare(c.Globals.Client, serviceID, version.Number, path, progress, out)
if err != nil {
return err
Expand Down