Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a record of errors to disk #340

Merged
merged 33 commits into from
Jul 20, 2021
Merged

Log a record of errors to disk #340

merged 33 commits into from
Jul 20, 2021

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Jul 8, 2021

To aid debugging, when running the CLI, track any errors in a log file.

@Integralist Integralist added the enhancement New feature or request label Jul 8, 2021
@Integralist Integralist requested a review from triblondon July 8, 2021 17:29
@Integralist
Copy link
Collaborator Author

Integralist commented Jul 8, 2021

The new /pkg/errors/testdata/... files I'm using for the tests aren't committed? So trying to figure out why.

I imagine it's something to do with the .gitignore?

UPDATE: figured it out, it was my global gitignore that had accidentally triggered the files to be omitted 🤦🏻 .

So I added the following to my gitignore so that I don't stumble over this in future...

*.log
+ !**/testdata/*.log

@Integralist Integralist marked this pull request as draft July 11, 2021 12:34
@Integralist Integralist force-pushed the integralist/error-log branch from 0f373bf to 46c51f7 Compare July 15, 2021 10:39
@Integralist Integralist force-pushed the integralist/error-log branch 3 times, most recently from 79915cf to 820cdf2 Compare July 15, 2021 18:33
@Integralist Integralist marked this pull request as ready for review July 15, 2021 21:29
@Integralist Integralist force-pushed the integralist/error-log branch from 065cfb5 to 06a3a28 Compare July 16, 2021 17:20
@Integralist Integralist force-pushed the integralist/error-log branch from 06a3a28 to 6df553f Compare July 20, 2021 10:51
@Integralist Integralist merged commit 2b6aa68 into main Jul 20, 2021
@Integralist Integralist deleted the integralist/error-log branch July 20, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants