validate package size doesn't exceed limit #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested review from
a team,
triblondon and
kailan
and removed request for
a team
JakeChampion
reviewed
Sep 2, 2021
Comment on lines
+345
to
+350
| if pkgSize > PackageSizeLimit { | ||
| return pkgName, pkgPath, errors.RemediationError{ | ||
| Inner: fmt.Errorf("package size is too large (%d bytes)", pkgSize), | ||
| Remediation: errors.PackageSizeRemediation, | ||
| } | ||
| } |
There was a problem hiding this comment.
Nice, I like the remediation pointing to the resource limits page 👍
JakeChampion
approved these changes
Sep 2, 2021
Integralist
force-pushed
the
integralist/package-size-error
branch
from
831d4f6 to
87618ed
Compare
triblondon
reviewed
Sep 2, 2021
| // current package size limit. | ||
| var PackageSizeRemediation = strings.Join([]string{ | ||
| "Please check our Compute@Edge resource limits:", | ||
| "https://docs.fastly.com/products/compute-at-edge-billing-and-resource-limits#resource-limits", |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks @triblondon. Once that content is available there we should update the code to reference the new location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #362