-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The compute init --from
flag should support archives and use content-negotiation
#428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
commented
Oct 6, 2021
02e06b6
to
538486c
Compare
538486c
to
7389e6a
Compare
7389e6a
to
a68c7dd
Compare
58d0785
to
5b06fbb
Compare
5b06fbb
to
7181ae9
Compare
compute init --from
flag should support fiddlescompute init --from
flag should support archives and use content-negotiation
triblondon
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements supporting
.zip
and.tar.gz
with the--from
flag value.The URLs I've used for testing are:
I'm blocked validating the content negotiation with an endpoint (such as fiddle) until fiddle implements serving back a .zip or .tar.gz when the
Accept
request header sends an appropriate value.Screenshots
Below is a snapshot of the contents of the
fastly.toml
and the list of files in the specified--path
directory. This shows the CLI extracted the files from the .zip file successfully and we updated the manifest with the values from the prompts...Extras
Also notice that the user is no longer prompted for a language when using the
--from
flag.I also fixed a bug I discovered when using
--from
with--path
.