fix shell autocomplete evaluation #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailan
approved these changes
Oct 14, 2021
Integralist
force-pushed
the
integralist/broken-autocomplete
branch
from
6e11b63 to
6e7f080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing an issue with the autocomplete flags not working at all, and causing homebrew upgrades to reveal a runtime error I then discovered that the autocomplete feature itself was only partially working (mostly broken).
This PR fixes this by ensuring
fastly --completion-bashproduces the expected output. I've also added a test to validate the behaviour so we'll know if we break it in future.