Support Viceroy "inline-toml" format and new contents field.
#567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `file` optional as well. This is an interim solution while a more robust one is investigated that is `format` aware, that's it, so either `file` or `contents` are added even if empty, depending on whether the `format` is `json` or `inline-toml`, respectively.
|
Tests are missing. Happy to have a chat about a better solution. |
Integralist
changed the title
format and new contents field.
Integralist
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
fileoptional as well. This is an interim solution while amore robust one is investigated that is
formataware, that's it,so either
fileorcontentsare added even if empty, dependingon whether the
formatisjsonorinline-toml, respectively.