Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rust output regression #658

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

Integralist
Copy link
Collaborator

NOTE: This was first seen in CI but can be reproduced by uninstalling all toolchains (e.g. rustup toolchain uninstall <toolchain>) and then running rustup show active-toolchain (see output below). The CLI was expecting one line of output but in fact there is now multiple lines, and the line we're interested in is actually the last line of output.

info: syncing channel updates for 'stable-aarch64-apple-darwin'
info: latest update on 2022-09-22, rust version 1.64.0 (a55dd71d5 2022-09-19)
info: downloading component 'cargo'
info: downloading component 'clippy'
info: downloading component 'rust-docs'
 18.8 MiB /  18.8 MiB (100 %)  11.3 MiB/s in  1s ETA:  0s
info: downloading component 'rust-std'
 25.6 MiB /  25.6 MiB (100 %)  10.5 MiB/s in  2s ETA:  0s
info: downloading component 'rustc'
 49.1 MiB /  49.1 MiB (100 %)   9.6 MiB/s in  5s ETA:  0s
info: downloading component 'rustfmt'
info: installing component 'cargo'
info: installing component 'clippy'
info: installing component 'rust-docs'
 18.8 MiB /  18.8 MiB (100 %)   6.4 MiB/s in  2s ETA:  0s
info: installing component 'rust-std'
 25.6 MiB /  25.6 MiB (100 %)  18.3 MiB/s in  1s ETA:  0s
info: installing component 'rustc'
 49.1 MiB /  49.1 MiB (100 %)  20.8 MiB/s in  2s ETA:  0s
info: installing component 'rustfmt'
stable-aarch64-apple-darwin (default)

@Integralist Integralist added the bug Something isn't working label Oct 5, 2022
@Integralist Integralist requested a review from triblondon October 5, 2022 10:13
Copy link
Contributor

@triblondon triblondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder about maybe filtering out lines that start with whitespace or 'info:', or investigating whether there's an option for this command to be less verbose so it doesn't print the syncing output? But assuming those are not viable / considered less optimal solutions, this is good!

@Integralist Integralist merged commit 4bc2c2b into main Oct 5, 2022
@Integralist Integralist deleted the integralist/v4-fix-rust-extra-output branch October 5, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants