Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing --help flag to globals #695

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Add missing --help flag to globals #695

merged 1 commit into from
Oct 26, 2022

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Oct 26, 2022 •
edited
Loading

--help is a Kingpin global flag but it was missing from the list of global flags to check for.

@Integralist Integralist added the bug Something isn't working label Oct 26, 2022
@Integralist Integralist requested a review from fgsch October 26, 2022 16:56
fgsch
fgsch approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@fgsch fgsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@Integralist Integralist merged commit 659296e into main Oct 26, 2022
@Integralist Integralist deleted the integralist/runtime-panic branch October 26, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgsch fgsch fgsch approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integralist @fgsch