Add account name to pubsub and bigquery #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grantstephens there's been a v7 release now so you can continue on with this PR. |
grantstephens
force-pushed
the
grantstephens/add-account-name-google
branch
from
179812d to
d073f7b
Compare
grantstephens
force-pushed
the
grantstephens/add-account-name-google
branch
from
d345623 to
ebb899a
Compare
Integralist
requested changes
Nov 21, 2022
| @@ -366,7 +370,7 @@ func getBigQueryError(i *fastly.GetBigQueryInput) (*fastly.BigQuery, error) { | |||
| return nil, errTest | |||
| } | |||
|
|
|||
| var describeBigQueryOutput = "\n" + strings.TrimSpace(` | |||
| var describeBigQueryOutput = "\n" + strings.TrimSpace(`Account name: `+` | |||
There was a problem hiding this comment.
I think this can be simplified to:
Suggested change
| var describeBigQueryOutput = "\n" + strings.TrimSpace(`Account name: `+` | |
| var describeBigQueryOutput = "\n" + strings.TrimSpace(`Account name: |
There was a problem hiding this comment.
Yes and no- depending on your editor it removes the space after account name and then the test fails- this is a hacky way around it- the other way is to set it to an actual value so that it isn't a blank line./
There was a problem hiding this comment.
Fixed in 4e0a709
Sorry, forgot I'd done this in trying to get the tests working
Co-authored-by: Mark McDonnell <[email protected]>
Integralist
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocked waiting for a new release of go-fastly. The tests need to be updated, but it cannot be tested without the release, so waiting on that.