Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(setup/domain): allow user to correct a domain already in use #811

Merged
merged 4 commits into from
Feb 9, 2023
Merged

fix(setup/domain): allow user to correct a domain already in use #811

merged 4 commits into from
Feb 9, 2023

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Feb 9, 2023 •
edited
Loading

Fixes #803

Screenshot 2023-02-09 at 15 49 33

@Integralist Integralist added the bug Something isn't working label Feb 9, 2023
JakeChampion
JakeChampion approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@JakeChampion JakeChampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks correct to me 👍
I've left one comment about a potential typo but I won't block approval on that

@Integralist @JakeChampion
refactor(setup/domain): typo
b1d859f 
Co-authored-by: Jake Champion <[email protected]>
@Integralist Integralist force-pushed the integralist/fix-domain-already-used branch from 3e6c643 to b8399b0 Compare February 9, 2023 20:08
@Integralist Integralist force-pushed the integralist/fix-domain-already-used branch from b8399b0 to 5005380 Compare February 9, 2023 20:21
@Integralist Integralist merged commit 06a92af into main Feb 9, 2023
@Integralist Integralist deleted the integralist/fix-domain-already-used branch February 9, 2023 20:41
@Integralist Integralist mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeChampion JakeChampion JakeChampion approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggested domain from CLI already used by another customer
2 participants
@Integralist @JakeChampion