Correct Field size for magento_vcl #401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will correct a problem where the module_vcl field truncates VCL larger than 65,535 bytes, the default size of a MySQL "text" field type. Changing this will create the field as a longtext field instead.
Update UpgradeSchema.php
There was a problem hiding this comment.
This change would only apply for new installs of the module, and not to current users.
Also, it would make the column of type LONGTEXT with a available size of 4GiB, which is not really desired.
I made a new PR with the proper upgrade and version bump, and with the Magento way of implementing MEDIUMTEXT type.
|
@MartinPeverelli that's even better! I'd prefer mediumtext as well as that's what I used for testing. Shall I cancel this PR or are you planning to use this as a reference? |
|
Closed in favor of #402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current file creates a table where the field size truncates to 65,535 bytes because it creates a "text" field. Changing this results in the field being created as a longtext field instead.