Apply request processing only when Fastly is enabled #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fredden Thank you for the PR. Looks good to me. |
MickaelDatadome
pushed a commit
to DataDome/fastly-magento2
that referenced
this pull request
Oct 5, 2023
* Correct type hint for property * Skip rate limiting when Fastly is not enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When Fastly has been previously in use, but is no longer in use, some Fastly settings are still effective.
We have noticed this when working on development and staging copies of a website where Fastly is configured properly on production, but not in use on development nor staging environments; Magento is configured in these environments to use 'built-in' or 'varnish' as its full-page cache application.
Steps to reproduce