Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoIP Mapping Does Not Support Multi-site Instance take 2 #531

Merged
merged 2 commits into from
May 25, 2022

Conversation

dpotkoc
Copy link
Contributor

@dpotkoc dpotkoc commented May 3, 2022

This is improved version of: interactiv4@e858e36

this close #393

@vvuksan vvuksan merged commit 4d38585 into fastly:master May 25, 2022
@vvuksan
Copy link
Contributor

vvuksan commented Jun 2, 2022

Got this error when doing setup:upgrade

Fatal error: Declaration of Fastly\Cdn\Model\Config\Interceptor::getGeoIpMappingForCountry($countryCode) must be compatible with Fastly\Cdn\Model\Config::getGeoIpMappingForCountry(string $countryCode): ?int in /var/www/html/generated/code/Fastly/Cdn/Model/Config/Interceptor.php on line 470

@dpotkoc dpotkoc mentioned this pull request Jun 3, 2022
@dpotkoc
Copy link
Contributor Author

dpotkoc commented Jun 3, 2022

@vvuksan fix is in #537

@vvuksan vvuksan changed the title Fix/393 GeoIP Mapping Does Not Support Multi-site Instance take 2 Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoIP Mapping Does Not Support Multi-site Instance
2 participants