Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL header directive stale-while-revalidate #561

Merged
merged 3 commits into from
Aug 25, 2022

Conversation

dpotkoc
Copy link
Contributor

@dpotkoc dpotkoc commented Aug 25, 2022

this close #559

@vvuksan vvuksan merged commit 8f5465a into fastly:master Aug 25, 2022
@vvuksan
Copy link
Contributor

vvuksan commented Sep 1, 2022

Avaiable in 1.2.187

@lemhannes
Copy link

Hi @dpotkoc
I've got some issue with your change since the class Magento\GraphQlCache\Model\CacheableQuery is not provided automatically by the given dependencies of your composer.json.
The error looks like this:

    In ClassReader.php line 51:
                                                                                   
      Impossible to process constructor argument Parameter #1 [ <required> Magento\GraphQlCache\Model\CacheableQuery $cacheableQuery ] of Fastly\Cdn\Plugin\GraphQl\AfterRenderResult class                                              
                                                                                   
    
    In ClassReader.php line 71:
                                                                      
      Class Magento\GraphQlCache\Model\CacheableQuery does not exist  

I'm using version 1.2.189 of your module + Magento version 2.4.3-p3

Kind regards
Hannes

@dpotkoc
Copy link
Contributor Author

dpotkoc commented Oct 14, 2022

Hello @lemhannes what is the reason that you don't have module: magento/module-graph-ql-cache

If you check with composer you will see that Magento by default requires this module:
composer why magento/module-graph-ql-cache
magento/product-community-edition 2.4.3-p3 requires magento/module-graph-ql-cache (100.4.0)

Let us know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL Lacking Stale Content Delivery Time Implementation
4 participants