This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Skey purge authentication #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 29, 2014 16:06
* We only need to auth with API key for purges
| @@ -21,7 +21,7 @@ def self.service_id | |||
| end | |||
|
|
|||
| def self.client | |||
| raise NoAuthCredentialsProvidedError unless configuration.authenticatable? | |||
| raise NoAPIKeyProvidedError unless configuration.authenticatable? | |||
There was a problem hiding this comment.
Will users need to change their applications to follow this change?
I ask because I don't know if we follow semantic versioning for fastly-rails
There was a problem hiding this comment.
Good point. It's possible, probably unlikely though.
As for semantic versioning. Latest version is 0.1.6. We can bump to 1.0.0 or 0.2.0. Do you have a recommendation?
There was a problem hiding this comment.
Semantic versioning says we can break all the API we want during the 0.x series, so I have no objection to this change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses new feature in fastly-ruby 1.1.4 to require Fastly-Key auth when sending purge API requests.
Renames
NoAuthCredentialsProvidedErrortoNoAPIKeyProvidedErrorsince we don't need full auth.