-
Notifications
You must be signed in to change notification settings - Fork 67
Adds soft purging from fastly-ruby client #56
Conversation
* No changes need to be made to the FastlyRails module, as it already accepts an args splat * Follows https://github.com/fastly/fastly-ruby/blob/ca7197e8e592549a6d16a129b11f7 5828e7f4add/README.md#L147
Again, this hinges on https://github.com/fastly/fastly-ruby/blob/ca7197e8e592549a6d16a129b11f7 5828e7f4add/README.md#L147
@@ -1,3 +1,3 @@ | |||
module FastlyRails | |||
VERSION = "0.6.0" | |||
VERSION = "0.6.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make this a 0.7.0 bump since we are adding new methods now. (I know I said the opposite yesterday but that was before the new features.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed, git history updated.
One minor comment about the versioning but this LGTM. 👍 |
6716965
to
2c28c48
Compare
👍 |
Hey guys! Thanks for merging this. Previously I was using the ruby client to soft purge and now wanted to take full advantage of the Rails gem and just tried it out with 0.7.0. I tried soft purge on an ActiveRecord model and it didn't work and got this instead:
I'm on Rails 4.2.4 + Ruby 2.2.2. Fwiw, I was previously doing this before the soft_purge support:
Thanks, |
@samratjp let's bring this over to an issue and work it out. |
soft_purge
,soft_purge_all
class/instance methods within ActiveRecord. Useful for callbacks, or calling on an instance of an ActiveRecord modelConcerns:
Mongoid
?