Refactor and add timestamp fields #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change data type from string to time of all timestamp fields. fix #117
Change data type from string to time of all timestamp fields. fix #117
Add support for created_at, updated_at, and deleted_at fields.
Add support for created_at, updated_at, and deleted_at fields.
Add support for created_at, updated_at, and deleted_at fields.
trentrosenbaum
suggested changes
Jun 12, 2019
There was a problem hiding this comment.
Pleased to see that the structs are consistent. I have added comments to get the build working. The only test that even tries to confirm the three fields is the service_test.go and that is really just saying are they populated or not. They do not confirm the format. This is understandable as dates can change if the fixtures need to be repopulated.
Overall it looks ok and once the changes are complete then the tests will pass.
Change data type from string to time of all timestamp fields. fix #117
Change data type from string to time of all timestamp fields. fix #117
Change data type from string to time of all timestamp fields. fix #117
Add support for created_at, updated_at, and deleted_at fields.
Change data type from string to time of created_at field fix #117
Add support for created_at, updated_at, and deleted_at fields.
Add support for created_at, updated_at, and deleted_at fields.
Add support for created_at, updated_at, and deleted_at fields.
Add support for created_at, updated_at, and deleted_at fields.
Add support for created_at, updated_at, and deleted_at fields.
Add support for created_at, updated_at, and deleted_at fields.
trentrosenbaum
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉this closes #117.