Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Compatibools for IgnoreIfSet input. #17

Merged
merged 1 commit into from
Jul 5, 2016
Merged

Conversation

alienth
Copy link
Contributor

@alienth alienth commented Jul 2, 2016

Right now it is impossible to set this field to true up in Fastly since it is sending up 'true' strings, which fastly will silently translate to '0'. This change fixes that.

Note that if anyone is using this lib is setting this field to true, this change will make that actually happen, which may result in unexpected consequences.

@sethvargo
Copy link
Contributor

Ping @catsby - this okay?

@catsby
Copy link
Contributor

catsby commented Jul 5, 2016

It is! Thanks @alienth

@sethvargo sethvargo merged commit e195721 into fastly:master Jul 5, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants