Support for the link to the rule set deploy status #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippschulte
force-pushed
the
pschulte/support-for-the-link-to-the-rule-set-deploy-status
branch
from
423dc5a to
1ccfb1d
Compare
phamann
approved these changes
May 12, 2020
philippschulte
force-pushed
the
pschulte/support-for-the-link-to-the-rule-set-deploy-status
branch
from
45903fb to
f5fc665
Compare
|
@phamann I have added the missing tests. Thank you! |
philippschulte
deleted the
pschulte/support-for-the-link-to-the-rule-set-deploy-status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is necessary in order to be able to use the link of the rule set deploy status in waflyctl.
The request methods for GET/service/service_id/wafs/waf_id/ruleset and PATCH/service/service_id/wafs/waf_id/ruleset share the same response struct. However, the responses of these endpoints are actually differnet. The
PATCHendpoint doesn't support thevcland thelast_pushfields.I am just adding the
Linkfield to the sharedRulesetresponse struct. This field will be empty and useless for the GET/service/service_id/wafs/waf_id/ruleset request function but I don't think this matters because the response struct for PATCH/service/service_id/wafs/waf_id/ruleset also includes empty and useless fields as well. Thejsonapipackage doesn't allow me to decode theLinkfield and therefore I am using the standard library for the job.I understand that this is not the nicest implementation but it doesn't introduce any breaking changes.