Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NullString helper #187

Merged
merged 1 commit into from
May 19, 2020
Merged

Add NullString helper #187

merged 1 commit into from
May 19, 2020

Conversation

ezkl
Copy link
Contributor

@ezkl ezkl commented May 18, 2020 •
edited
Loading

Adds a NullString helper that either returns a pointer to the string value passed in or nil if it the string is empty ("").

@ezkl ezkl force-pushed the ezkl/string-helper-return-nil branch from 1111053 to 37e704d Compare May 18, 2020 21:04
@ezkl ezkl changed the title Update String helper to return nil instead of an empty string Add NullString helper that returns nil instead of an empty string May 18, 2020
@ezkl ezkl changed the title Add NullString helper that returns nil instead of an empty string Add NullString helper May 18, 2020
mccurdyc
mccurdyc approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@mccurdyc mccurdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mccurdyc mccurdyc requested a review from phamann May 18, 2020 21:09
phamann
phamann approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM other than the comment nit.

fastly/fastly.go Outdated Show resolved Hide resolved
@ezkl ezkl force-pushed the ezkl/string-helper-return-nil branch from 37e704d to 5fe1563 Compare May 19, 2020 13:25
@ezkl
Add NullString helper
0956a84 
Returns a pointer to the string value passed in or nil if the string
is empty.
@ezkl ezkl force-pushed the ezkl/string-helper-return-nil branch from 5fe1563 to 0956a84 Compare May 19, 2020 13:48
@ezkl ezkl merged commit e3fe420 into fastly:master May 19, 2020
@ezkl ezkl deleted the ezkl/string-helper-return-nil branch May 19, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

@mccurdyc mccurdyc mccurdyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezkl @phamann @mccurdyc