Fix testing behavior for logging endpoints the support compression #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the testing behavior around the simultaneous use of the compression_codec and gzip_level options for logging endpoints that support compression.
Integralist
requested changes
Apr 14, 2021
I double-checked and I only see changes to fixture files for the affected tests. Was there any in particular you thought didn't belong? |
Integralist
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
My bad @kellymclaughlin I missed the files at the end of the fixtures 🤦🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the testing behavior around the simultaneous use of the
compression_codecandgzip_leveloptions for logging endpoints that support compression.This relates to discussion on fastly/cli#190.