Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain validation API #298

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Add domain validation API #298

merged 4 commits into from
Sep 13, 2021

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist added the enhancement New feature or request label Sep 13, 2021
@Integralist Integralist requested review from a team and kailan and removed request for a team September 13, 2021 13:59
Comment on lines +283 to +284
// UnmarshalJSON works around the badly designed API response by coercing the
// raw data into a more appropriate data structure.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kailan @doramatadora @triblondon

This is an interesting example of where code generating the go-fastly client might present problems.

e.g. it's unlikely that the generated code will try to handle this situation (i.e. multiple types within an array) intelligently as it won't know the context of the response data.

I imagine it will more likely just generate code that uses the empty interface type interface{}, which will cause more problems for consumers of the library as they'd then need to type assert the interface{} into a concrete type.

@Integralist Integralist merged commit 6dceb3e into main Sep 13, 2021
@Integralist Integralist deleted the integralist/domain-validation branch September 13, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants