-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Link header pagination #321
Add support for Link header pagination #321
Conversation
2298c2b
to
341b20f
Compare
7fdcf35
to
d209ee3
Compare
d209ee3
to
c1ccea3
Compare
@Integralist let me know if you have any questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but have a couple of suggestions.
Out of interest, do you happen to know how to get the generated documentation to display an example snippet like in your PR description (not sure if that's done by adding the snippet into a code comment above the code function)?
@Integralist Thanks. Applied all suggestions and added code examples. Tested this locally using godoc. This should work. |
client example:
Adding
NewListACLEntriesPaginator
andNewListDictionaryItemsPaginator
.