Revive #378
Merged
Revive #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
force-pushed
the
integralist/revive
branch
from
59d6498 to
a508562
Compare
Integralist
force-pushed
the
integralist/revive
branch
5 times, most recently
from
fe11410 to
bf2d7e3
Compare
Integralist
force-pushed
the
integralist/revive
branch
from
bf2d7e3 to
f23e984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running https://github.com/mgechev/revive (drop-in replacement for
golint) over the code base and fixing issues reported.Some of the changes were related to acronyms and so would be considered a breaking change due to the change in interface.
There is also a bunch of standardising changes being made to the function/documentation comments to keep them consistent.
I've also added lots of struct field description for documentation purposes and for developer LSP server's to be able to use to help them when developing using the go-fastly API client.