breaking(secret-store): rename ValidateSignature to VerifySignature #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A more technically correct term.
Integralist
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
LGTM but this will be a change in the exposed interface and so must be treated as a major version bump (i.e. to release this change we'd bump to 8.0.0). So if there are any other 'breaking' changes you think could do with made, then now would be the time to get those in.
Integralist
changed the title
|
In that case, let's sit on this for now. It's not a big deal (although I also guarantee nobody is using the old name so it's largely a technicality) so it's not worth making a major version bump for this alone. |
awilliams-fastly
approved these changes
Feb 16, 2023
Integralist
deleted the
joeshaw/verify-validate-lets-call-the-whole-thing-off
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more technically correct term.