mTLS #440
Merged
mTLS #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
force-pushed
the
integralist/mtls
branch
from
61f1eb1 to
5107034
Compare
Integralist
force-pushed
the
integralist/mtls
branch
from
5107034 to
8a1cfd2
Compare
joeshaw
reviewed
May 30, 2023
…d use slice for include property
|
Now that @joeshaw's other comments have been addressed I'm going to merge this PR later today. |
| } | ||
|
|
||
| // Create private key required to generate a custom certificate. | ||
| var pk *PrivateKey |
There was a problem hiding this comment.
I think adding these in table-driven tests format would be concise and easily extendible. You can also add a cleanup func for each test case which you can run after executing the case to get rid of defer statements.
This is just a suggestion, and not a blocker to merge this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.