Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notifications #513

Merged
merged 5 commits into from
Apr 16, 2024
Merged

feat: notifications #513

merged 5 commits into from
Apr 16, 2024

Conversation

darin-nee
Copy link
Contributor

This adds support for configuring notifications.

Fastly API docs: https://www.fastly.com/documentation/reference/api/observability/notifications/

Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @darin-nee just a couple of comments that probably apply broadly.

fastly/notifications.go Outdated Show resolved Hide resolved
fastly/notifications.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @darin-nee for addressing the feedback. I've just one remaining comment (if you could apply globally/wherever relevant). Thanks!

fastly/notifications.go Outdated Show resolved Hide resolved
@darin-nee darin-nee requested a review from Integralist April 16, 2024 15:57
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Integralist Integralist merged commit c2747f0 into main Apr 16, 2024
4 checks passed
@Integralist Integralist deleted the darin-nee/feat-notifications branch April 16, 2024 16:54
@Integralist
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants