Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(computeacls): Add support for Compute platform ACLs. #574

Merged
merged 20 commits into from
Jan 25, 2025
Merged

feat(computeacls): Add support for Compute platform ACLs. #574

merged 20 commits into from
Jan 25, 2025

Conversation

philippschulte
Copy link
Member

@philippschulte
Copy link
Member Author

Tests are failing because query strings are currently not URL decoded. go-fastly always URL encodes every request. Work is in progress to get it fixed.

==> Testing go-fastly
--- FAIL: TestClient_ComputeACL (3.89s)
    compute_acl_test.go:209: error during IP lookup pagination: 400 - Bad Request:
        
            Title:  invalid cursor

@kpfleming kpfleming self-requested a review January 10, 2025 17:01
@philippschulte philippschulte marked this pull request as ready for review January 22, 2025 04:45
Integralist
Integralist reviewed Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpfleming Should this use the new design? e.g. #577

@philippschulte
Copy link
Member Author

@kpfleming Should this use the new design? e.g. #577

Addressed in 7d6e0fb.

Integralist
Integralist approved these changes Jan 24, 2025
View reviewed changes
fastly/computeacl/v1/api_delete.go Outdated Show resolved Hide resolved
fastly/computeacl/v1/api_describe.go Outdated Show resolved Hide resolved
fastly/computeacl/v1/api_list_acls.go Outdated Show resolved Hide resolved
fastly/computeacl/v1/api_list_entries.go Outdated Show resolved Hide resolved
fastly/computeacl/v1/api_lookup.go Outdated Show resolved Hide resolved
fastly/computeacl/v1/api_response.go Outdated Show resolved Hide resolved
fastly/computeacl/v1/api_update.go Outdated Show resolved Hide resolved
fastly/computeacl/v1/api_update.go Outdated Show resolved Hide resolved
fastly/computeacl/v1/api_update.go Outdated Show resolved Hide resolved
fastly/computeacl/v1/api_update.go Outdated Show resolved Hide resolved
philippschulte and others added 13 commits January 24, 2025 08:42
@philippschulte @Integralist
chore(api_delete.go): update struct field description
787427e 
Co-authored-by: Mark McDonnell <[email protected]>
@philippschulte @Integralist
chore(api_describe.go): update struct field description
e66c9a7 
Co-authored-by: Mark McDonnell <[email protected]>
@philippschulte @Integralist
chore(api_list_entries.go): update struct field description
13c05e7 
Co-authored-by: Mark McDonnell <[email protected]>
@philippschulte @Integralist
chore(api_lookup.go): update struct field description
3ccc553 
Co-authored-by: Mark McDonnell <[email protected]>
@philippschulte @Integralist
chore(api_lookup.go): update struct field description
9d36248 
Co-authored-by: Mark McDonnell <[email protected]>
@philippschulte @Integralist
chore(api_response.go): add struct field description
416545a 
Co-authored-by: Mark McDonnell <[email protected]>
@philippschulte @Integralist
chore(api_response.go): add struct field description
60edb37 
Co-authored-by: Mark McDonnell <[email protected]>
@philippschulte @Integralist
chore(api_update.go): update struct field description
8d9914f 
Co-authored-by: Mark McDonnell <[email protected]>
@philippschulte @Integralist
chore(api_update.go): add struct field description
b76dde9 
Co-authored-by: Mark McDonnell <[email protected]>
@philippschulte @Integralist
chore(api_update.go): add struct field description
5ff3905 
Co-authored-by: Mark McDonnell <[email protected]>
@philippschulte @Integralist
chore(api_update.go): add struct field description
830fbf2 
Co-authored-by: Mark McDonnell <[email protected]>
@philippschulte @Integralist
chore(api_response.go): add struct field description
07aaf5a 
Co-authored-by: Mark McDonnell <[email protected]>
@philippschulte @Integralist
chore(api_response.go): add struct field description
2c36a68 
Co-authored-by: Mark McDonnell <[email protected]>
@kpfleming kpfleming changed the title Add support for compute ACLs feat(computeacls): Add support for Compute platform ACLs. Jan 25, 2025
@kpfleming kpfleming merged commit 5632665 into fastly:main Jan 25, 2025
3 checks passed
@philippschulte philippschulte deleted the pschulte/add-support-for-compute-acls branch January 26, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfleming kpfleming kpfleming approved these changes

@Integralist Integralist Integralist approved these changes

Assignees
No one assigned
Labels
include-in-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philippschulte @Integralist @kpfleming @anthony-gomez-fastly