skip any dynamic snippets in #flattenSnippets #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents adding dynamic snippets to the list of all snippets. Therefore the provider won't delete any dynamic snippets if there are any changes in the pipeline. fix #98
ghost
added
the
philippschulte
changed the title
thommahoney
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #98
To fix this issue there is no need to add the
dynamicfield to thesnippetschema like proposed in hynd@9bfd203. It's only necessary to prevent addingdynamicsnippets to the list of all snippets. That waydynamicsnippets will be ignored if there are any changes in the pipeline.I wanted to avoid having any references to
dynamicsnippets in the source code because the provider only supportsregularsnippets. This won't change until the Fastly API provides thecontentfordynamicsnippets.