Add support for override host field #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
trentrosenbaum
suggested changes
Jun 10, 2019
There was a problem hiding this comment.
From the point of view of introducing a new field, this looks ok and the field is documented in the provider and on the fastly api website. I cannot see any documented validation and so this should be fine.
The current build is failing and so just marking it as "Request Changes" to see a green build.
The override_host field can be used to override the Host header. fix #163
BREAKING CHANGE: API for BigQuery logging has changed in v1.0.0 and needs to be adjusted in the provider. fix #163
The go-fastly client API for BigQuery has changed in v1.0.0.
The go-fastly client API for Director has changed in v1.0.0.
The go-fastly client API for VCL Snippets has changed in v1.0.0.
|
@trentrosenbaum the build wasn't passing because the client hasn't been updated. The PR updates the |
trentrosenbaum
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉this closes #163.