Add support for FTP logging #235
Conversation
ghost
added
| Description: "The unique name of the FTP logging endpoint", | ||
| }, | ||
|
|
||
| "address": { |
There was a problem hiding this comment.
Just making note that for FTP we don't explicitly expose IPV4 or Hostname because Address includes these values.
| if errRes, ok := err.(*fst.HTTPError); ok { | ||
| if errRes.StatusCode != 404 { | ||
| return err | ||
| } | ||
| } else if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Wouldn't a 404 error returned from DeleteFTP result in a nil error being returned from this function? Is that expected?
There was a problem hiding this comment.
Why can't we simply have the following here:
return conn.DeleteFTP(i)| @@ -1574,6 +1575,7 @@ func resourceServiceV1Update(d *schema.ResourceData, meta interface{}) error { | |||
| "splunk", | |||
| "blobstoragelogging", | |||
| "httpslogging", | |||
| "logging_ftp", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I agree with this decision of starting to introduce consistency with logging_foo
|
Force-pushed rebasing master. |
|
Force-pushed rebasing master. |
mccurdyc
force-pushed
the
ezkl/add-ftp
branch
2 times, most recently
from
fc903ab to
6b55c98
Compare
| path = "/path" | ||
| port = 27 | ||
| format = "%%h %%l %%u %%t \"%%r\" %%>s %%b" | ||
| gzip_level = 3 |
There was a problem hiding this comment.
This really bothers me. This must be my tab width or something. It looks fine locally.
It would be nice if we could leverage Terraform's terraform fmt. Maybe if we pulled these out into *.tf test fixtures?
But I also kind of don't like pulling the test data that far from the test itself. Thoughts? Other ideas?
There was a problem hiding this comment.
I think the idea of .tf test fixtures to solve this issue, though does add some overhead to adding tests.
mccurdyc
force-pushed
the
ezkl/add-ftp
branch
2 times, most recently
from
87fc21e to
f19b4dc
Compare
| Address: "ftp2.example.com", | ||
| Username: "user", | ||
| Password: "p@ssw0rd2", | ||
| PublicKey: pgpPublicKey() + "\n", // The '\n' is necessary becaue of the heredocs (i.e., EOF) in the config below. |
There was a problem hiding this comment.
Note this ugly + "\n" and accompanying comment.
This is b/c of this.
mccurdyc
force-pushed
the
ezkl/add-ftp
branch
2 times, most recently
from
ae1c1e1 to
66d909d
Compare
Signed-off-by: Colton J. McCurdy <[email protected]>
Adds support for configuring FTP log streaming (API docs) to provider.
cc: @phamann