Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Armored PGP Key for Tests and SFTP, BigQuery use trimSpaceStateFunc #268

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Armored PGP Key for Tests and SFTP, BigQuery use trimSpaceStateFunc #268

merged 2 commits into from
Jun 22, 2020

Conversation

mccurdyc
Copy link
Collaborator

@mccurdyc mccurdyc commented Jun 19, 2020 •
edited
Loading

There were acceptance test failures due to a non-armored pgp key.

This was most-likely introduced when fixing merge conflicts.

$ gpg --list-key 491A054E0D1CBFD7371B5653C0A0ED736D11CD5B
pub   rsa2048 2020-06-19 [SC]
      491A054E0D1CBFD7371B5653C0A0ED736D11CD5B
uid           [ultimate] FooBar <[email protected]>
sub   rsa2048 2020-06-19 [E]

@ghost ghost added the size/M label Jun 19, 2020
@mccurdyc
tests: use armored pgp key
50c1af5 
Signed-off-by: Colton J. McCurdy <[email protected]>
phamann
phamann reviewed Jun 22, 2020
View reviewed changes
fastly/fastly_test.go
zny1Rn8/BNa/GvYQzfcMxDUIk5xnv6/olmEDWswUL0OHXOCOf+FnWHXso0gcnrAu
1/YjhVeSYa8UN7gwO6+rOGlpY/XL60Fozg9vzTYDMrk=
=FSt9

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this new line meant to be here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. This is added when you armor the key.

@mccurdyc
sftp: use trim whitespace statefunc
3fffef1 
Signed-off-by: Colton J. McCurdy <[email protected]>
phamann
phamann approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phamann phamann merged commit 5c0bce6 into fastly:master Jun 22, 2020
@mccurdyc mccurdyc deleted the mccurdyc/test-pgp-key branch June 22, 2020 15:43
@mccurdyc mccurdyc changed the title tests: use armored pgp key Armored PGP Key for Tests and SFTP, BigQuery use trimSpaceStateFunc Jun 22, 2020
@mccurdyc mccurdyc mentioned this pull request Apr 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccurdyc @phamann