Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GZIP -> Gzip #279

Merged
merged 1 commit into from
Jun 30, 2020
Merged

GZIP -> Gzip #279

merged 1 commit into from
Jun 30, 2020

Conversation

mccurdyc
Copy link
Collaborator

Proposed Change(s)

  • Standardize on Gzip ubiquitously.

Validation:

find . -path ./vendor -prune -type f -exec sed -i 's/GZIP/Gzip/g' {} \;

@mccurdyc mccurdyc requested a review from phamann June 29, 2020 15:15
mccurdyc
mccurdyc commented Jun 29, 2020
View reviewed changes
fastly/block_fastly_service_v1_gzip.go
@@ -9,19 +9,19 @@ import (
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
)

type GZIPServiceAttributeHandler struct {
type GzipServiceAttributeHandler struct {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No one should really be consuming this API, so this should be safe.

phamann
phamann approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mccurdyc
*: GZIP -> Gzip
9e157f5 
Signed-off-by: Colton J. McCurdy <[email protected]>
@mccurdyc mccurdyc merged commit bd24d3f into fastly:master Jun 30, 2020
@mccurdyc mccurdyc deleted the mccurdyc/docs-fix-typo branch June 30, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

Assignees
No one assigned
Labels
documentation size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccurdyc @phamann