Ensure we still read/refresh remote state when activate is set to false. #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phamann
commented
Dec 13, 2020
fastly/base_fastly_service_v1.go
Outdated
| // service version details call. This is to ensure we still read all of the | ||
| // state below. | ||
| shouldActivate := d.Get("activate").(bool) | ||
| if s.ActiveVersion.Number == 0 && isImport || !shouldActivate { |
There was a problem hiding this comment.
I'm on the fence if this this is the cleanest way of solving this, or instead changing the gate on read conditional logic on line 165. Thoughts?
There was a problem hiding this comment.
Let's talk through the alternative implementation first before we go ahead and approve/merge this changeset.
phamann
force-pushed
the
phamann/dictionary-active
branch
from
4392401 to
356f8d8
Compare
Integralist
approved these changes
Dec 15, 2020
|
As discussed with @Integralist separately, this is now ready to merge and full acceptance test suite is passing (other than some unrelated WAF ones which are broken due to external API changes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixes an edge case in the
fastly_service_*resources, in which we don't refresh remote state if theactivatefield is set tofalse. This was introduced in #269, when we refactored the service resources to the "block" model and introduced the base service definition interface.What?
After a couple of bug reports related to
activate = falsevia Fastly support, we investigated further and found that if a configuration has theactivatefield set to false AND it has no previous active version the state wasn't being read. This manifested itself as a runtime error in certain situations, such as another resource referencing the state in its configuration.It turns out we were assuming that the service will always have an active version number greater than 0 within the
Readmethod and gating the read on that condition.Fixes: hashicorp/terraform#27258
Note:
I've ran the tests I introduced in this PR to confirm this fixes the issue. However still ned to run the full suite before merging, which I'll try and do in the coming days.