Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service test sweeper #373

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Add service test sweeper #373

merged 1 commit into from
Feb 25, 2021

Conversation

bengesoff
Copy link
Contributor

Sometimes errors in acceptance tests can leave leaked services in the Fastly account. This sweeper adds support for cleaning these up with the make sweep command. This goes through the services and deletes the ones whose names start with tf-test- (the convention that the tests all use). The TLS sweepers work in the same way.

@bengesoff bengesoff marked this pull request as ready for review February 24, 2021 15:07
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @bengesoff

@Integralist Integralist added the enhancement New feature or request label Feb 25, 2021
@Integralist Integralist merged commit 393c952 into fastly:master Feb 25, 2021
@trentrosenbaum trentrosenbaum deleted the service-sweeper branch March 15, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants